Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

click and drag outside the Z window crasches GC #780

Closed
GeroBH opened this issue Oct 19, 2018 · 3 comments · Fixed by #781
Closed

click and drag outside the Z window crasches GC #780

GeroBH opened this issue Oct 19, 2018 · 3 comments · Fixed by #781
Assignees
@BarbourSmith

Comments

@GeroBH
Copy link
Contributor

GeroBH commented Oct 19, 2018

As posted here https://forums.maslowcnc.com/t/zaxis-gc-close-out/7274
there is a bug crashing GC, confirmed with Windows and Ubuntu.
With GC 1.23 and back to GC 1.03

To replicate:
Open the Z menu, click and drag outside the Z window.

Credit for finding goes to TalleyMakeWork
@BarbourSmith
Copy link
Member

This sounds like something I should fix. I'm going to assign it to my self and jump on it!

@BarbourSmith BarbourSmith self-assigned this Oct 19, 2018
@BarbourSmith
Copy link
Member

BarbourSmith commented Oct 19, 2018 •
edited
Loading

It looks like the issue actually happens when clicking and dragging outside any popup I see it with the Actions popup also

BarbourSmith added a commit that referenced this issue Oct 19, 2018
@BarbourSmith
Add catch for KeyError exception
f9dac5f 
This exception when a motion was detected while a popup was open was causing the program to crash. No action is needed for this exception so it is now captured silently.

Fixes #780

Please test and upvote this pull request if the fix seams reasonable and works for you!
@BarbourSmith BarbourSmith mentioned this issue Oct 19, 2018
Merged
@GeroBH
Copy link
Contributor Author

GeroBH commented Oct 19, 2018

That was fast, guess 3 confirmed tests should be enough to close.

@GeroBH GeroBH closed this as completed Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BarbourSmith BarbourSmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add catch for KeyError exception MaslowCNC/GroundControl
2 participants
@BarbourSmith @GeroBH