Fix osx notification size #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some gcode creation programs sprinkle space runs within the gcode lines. This will condense all runs to a single space.
OSX screen resolution makes popups h- and v-size too to small to read content. Use size_hint to scale popup to the screen size, special case for darwin to avoid affecting other platforms.
|
❤️ ❤️ ❤️ Excellent! This feels like a mistake on my part to have used pixel specific numbers in the first place. Is there any reason we shouldn't use size hint on every platform? |
|
Popup doesn't understand the pixel specific (dp, sp) sizes, so this is the only universal way to control the size. Not sure about the other platforms, so I special-cased it. Getting rid of the special case would be cleaner 😉 |
|
Got it. I agree, let's use the new method for all OS's. I think that's how Kivy would have wanted us to do it 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSX screen resolution makes popups h- and v-size too to small to read content. Use size_hint to scale popup to the screen size, special case for darwin to avoid affecting other platforms.