Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sled to center of work area after finishing measure out chains step #442

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

BarbourSmith
Copy link
Member

Send a B15 command to move the sled to the center after the chain length step of the calibration process. A part of firmware issue #323

@blurfl
Copy link
Collaborator

blurfl commented Nov 1, 2017

Does this replace the step which moved the chains to 1650mm? That would mean re-painting the 'king link' every time the sled is changed, like going from the quad- to the triangular- or from the upper-pantograph- to the ring-sled, or it would mean running the motors every time the chain cal needs to be re-established
😔

@BarbourSmith
Copy link
Member Author

Great question!

No, it does not replace that step or interfere with the 'manual calibration' system. Or at least I hope it does not.

The way the new system works is that the chains are fed out to 1650mm and stop the same as before. The difference is that now when the 'Finish' button is pressed at the end of the step the chain lengths are adjusted to bring the sled to the center.

That was the best compromise I could come up with to try to meet all the goal, but I'm open to suggestions 👍

@blurfl
Copy link
Collaborator

blurfl commented Nov 1, 2017

That's a very good compromise. 👍 👍
It might be an idea to mention marking the top links (I really should load the code and see for myself, sorry for being lazy here) as an option at that point.

@BarbourSmith BarbourSmith merged commit a6b4fe8 into master Nov 1, 2017
@BarbourSmith BarbourSmith deleted the fix-for-firmware-issue-323 branch November 1, 2017 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants