Update frontPage.py to correct inches/mm conversion #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to convert from values on the screen from inches to mm (and vice versa) assumes used 1 in to 25 mm conversion factor. It's more accurate to use the values defined just above in the code
|
I'm getting the issue I was having before we went to 25 as the conversion factor where the conversion is happening with arbitrarily high precision making the text overflow like this:
|
|
Ah, well, I'll see if I can add some rounding to it. Let's see if I can edit the PR. |
|
Great solution! I think commiting to the same branch again should automatically update the pull request |
Added a formatting string to round to 2 decimal places
|
I think it updated. Python is strange (and new) to me. As with all things you don't know how to do, https://stackoverflow.com/questions/455612/limiting-floats-to-two-decimal-points FTW. |
|
Stack exchange is a life saver. This works great for me. Good fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to convert from values on the screen from inches to mm (and vice versa) assumes used 1 in to 25 mm conversion factor. It's more accurate to use the values defined just above in the code.
Just a little clean up.