Disable command to zero the axes in Step1 'Begin' button #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the issue I was seeing was caused by the 'Begin' button in Step1 - it executes gcode "B06 L0 R0" which tells both axes that they are at the first link of the chain. There is a comment "This prevents strange behavior when rotating each sprocket to 12:00". With the present code, clicking this button clobbers your chain calibration whether that was what you intended or not. I believe recent changes to kinematics and the chain calibration procedure make this 'Begin' button behaviour unnecessary.
|
I agree. I would just delete the line entirely. The sprocket movement commands are all incremental anyways, so there isn't really a chance for a big jump anymore. |
|
I was being cautious, but can do another commit with the line removed and the comment above it amended. |
|
I'm going to be honest I somehow missed that this is a pull request and not an issue. My comment was suggesting a pull request...but clearly you have already made one 😀 Hannah is out this week so I've got twice as many balls to juggle. This looks perfect. Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the issue I was seeing was caused by the 'Begin' button in Step1 - it executes gcode "B06 L0 R0" which tells both axes that they are at the first link of the chain. There is a comment "This prevents strange behavior when rotating each sprocket to 12:00".
With the present code, clicking this button clobbers your chain calibration whether that was what you intended or not.
I believe recent changes to kinematics and the chain calibration procedure make this 'Begin' button behaviour unnecessary.