Adjust KpV Value to Fix Choppy Movement Issue #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does make a noticeable difference. 👍 |
|
Beautiful! I'm really glad we got this into 1.03, I think a lot of people will appreciate it Thanks for testing @blurfl I don't see the issue so I can't test |
|
could you add some comments to these places, giving a rough idea of how to
experiment with these values (links to online explinations are a good start)
David Lang
|
|
I spent a lot of time putting this together a while ago: https://github.com/MaslowCNC/Firmware/wiki/PID-Tuning But honestly, a lot of this is just trial and error. |
|
please put a link to that page next to the parameters in the code.
David Lang
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix most if not all of the choppiness seen by some users.