Properly Treat Error Responses as Equivalent to ok #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grbl spec will send error: xxxx responses with no ok response. This tells GC to move on to the next message when such responses are received.
|
Thank you for doing a really good job of reading the standards and making sure we stick to them. Those sorts of things may be small fixes when taken independently, but together they make up the difference between a project which is a pleasure to use and work on and one that is dificult 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix. The Grbl spec will send error: xxxx responses with no ok response. This tells GC to properly move on to the next message when such responses are received.