Make it possible to extend chain by an arbitrary length #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything seems to work, but hasn't all been tested
|
I've wished for this since day one! The picture shows 'Number of Links' at the top left, 'Inches' in the dialog and Dist(MM) in the Settings panel, an opportunity for refinement... |
|
I fixed the "number of links" at the top, but I haven't fixed the inches/mm issue yet. I am going to merge this one anyway so that we can build off of it, and work on a fix for the inches/mm confusion...great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring you to extend the chain by 1000, 100, or 10mm you can now extend it by an arbitrary length entered using the standard text entry widget:
Fixes #350
Should not be merged until after #604
Needs to be fully tested during a calibration process before merging