A proposed fix for #306 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed fix for the issue where the machine will not move again after pressing the stop button. The solution is to indicate that when a stop has been sent it will free up the entire buffer. As soon as the OK message is recieved to indicate that the stop command has been processed the entire buffer is marked as free. One more change I would like to make if we like this solution is to change all of the hard coded 256s in there to be a #define so it is more clear why that number is used and the code can be easily modified for different buffer sizes. Closes #306
|
bufferSpace is already defined, we just don't seem to use it. |
|
I think that bufferSpace is the amount of space available in the buffer so I added a bufferSize variable which is the size of the buffer when empty and added a comment to clear it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for the issue where the machine will not move again after pressing the stop button.
The solution is to indicate that when a stop has been sent it will free up the entire buffer. As soon as the OK message is recieved to indicate that the stop command has been processed the entire buffer is marked as free.
One more change I would like to make if we like this solution is to change all of the hard coded 256s in there to be a #define so it is more clear why that number is used and the code can be easily modified for different buffer sizes.
Closes #306