-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Settings; Store Settings in Single Location #608
Conversation
Make a truly single source for all attributes about all settings. Added some helper functions as well. Change on_change_config to callback. Prior function was only called if setting was changed on the config page. This way it is actually called when a setting is changed no matter where.
Conflicts: UIElements/measureMachinePopup.py
Computed Settings are saved in the config file, but are not shown to the user. They are updated by a function whenever the relevant user settings are changed. This enables all settings details to be stored in one location rather than scattered about.
Will request all machine settings on serial connection. Anytime GC sees a setting report from the machine that doesn't match the GC value, that setting is updated. Settings are checked for closeness, because float values on arduino only have 6 guaranteed significant digits
Matching commit from firmware is MaslowCNC/Firmware#384 |
This crashes for me (using the matching firmware) with this output:
|
Can't just append length of line to the end, we will end up with a stack of line lengths that don't match.
Just in case we receive a spurious line starting with $ don't crash.
OK, this should work now @blurfl, thank you for catching that, it lead to the discovery of a number of small issues. |
This makes a few changes to the settings design that should make our life easier.
This requires a simultaneous update to the Firmware, so the version number should be changed.