Include note requiring restart #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include note that changing the setting for the chain wrapping on the top or bottom of the sprockets will require the Maslow board to be restarted.
|
I think we can fix this from the firmware side. If setupAxes then kinematics.init and then kinematics.forward is called whenever this setting is changed on the firmware, I think this will solve the issue. |
|
That would be great! I'm in the February order group, so I don't yet have a machine to test on. I was going to come back and try to get it working without a restart, but if that would do it then that would be much better! Have you tested that by chance? |
|
Great! I vote +1 for doing it on the firmware side, but I am going to merge this for now because 1.06 comes out tomorrow and we should not that a restart is required until we take care of it on the firmware side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include note that changing the setting for the chain wrapping on the top or bottom of the sprockets will require the Maslow board to be restarted.
I'm still working through some of the recent changes, so I haven't been able to get a more descriptive pop-up screen done. But this at least notifies the user that a restart is required.