Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new framework for calibration process #649

Merged

Conversation

BarbourSmith
Copy link
Member

@BarbourSmith BarbourSmith commented Feb 22, 2018

When the calibration process was originally written it was a very linear process which always progressed in the same way. It also has simply evolved a lot over time and had become cluttered and difficult to maintain.

This pull request attempts to re-write the way the calibration process framework works.

Each step is now a self contained widget and they can be loaded, removed, or reordered at any time. Changes to one step will not affect other steps.

Each calibration step has an on_Enter function and an on_Exit functions which are called when the step begins and when it finishes. When a step is done with whichever part of the calibration process it is working on, it calls the readyToMoveOn() function which will remove it from the display and load the next step.

The functionality is mostly in place in this pull request, however only one path through the calibration process is supported right now. The machine must use the chains passing over the top of the sprockets and triangular kinematics. I will add the other possible paths in separate pull requests because this one is already so massive, and because I want feedback and discussion on how to do the chains over the bottom option.

Graphically it looks very similar to how it did before:

image

I've run through everything once, but this shouldn't be considered stable yet. I want to test it quite a bit more before considering merging it. Any feedback is more than welcome.

@BarbourSmith
Copy link
Member Author

I'm feeling good enough about these to merge them 😀

@BarbourSmith BarbourSmith merged commit 86dbdeb into master Feb 26, 2018
@BarbourSmith BarbourSmith deleted the create-new-frame-widget-for-holding-calibration-widgets branch February 26, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant