Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix G38.2 metric default value #755

Conversation

blurfl
Copy link
Collaborator

@blurfl blurfl commented Aug 14, 2018

G38.2 defaults to 0.2" movement in inches mode, change the metric default to match. It was mistakenly set for 0.5mm, too small to be of value.

G38.2 defaults to 0.2" movement in inches mode, change the metric default to match.
@MaslowCommunityGardenRobot
Copy link
Collaborator

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

@MaslowCommunityGardenRobot
Copy link
Collaborator

Time is up and we're ready to merge this pull request. Great work!

@MaslowCommunityGardenRobot MaslowCommunityGardenRobot merged commit 7841f94 into MaslowCNC:master Aug 16, 2018
@BarbourSmith
Copy link
Member

It's awesome to see this process working while I was away ❤️ ❤️ 👍 👍 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants