Issue while running Craft Command

Describe the bug
If you use any command with craft it gives an error.

Traceback (most recent call last):
  File "craft", line 12, in <module>
    from wsgi import container
  File "/Users/yubarajshrestha/Python Projects/blog/wsgi.py", line 36, in <module>
    located_provider.load_app(container).register()
  File "/Users/yubarajshrestha/Python Projects/blog/venv/lib/python3.8/site-packages/masonite/providers/AppProvider.py", line 58, in register
    self._autoload(config("application.autoload"))
  File "/Users/yubarajshrestha/Python Projects/blog/venv/lib/python3.8/site-packages/masonite/providers/AppProvider.py", line 67, in _autoload
    Autoload(self.app).load(directories)
  File "/Users/yubarajshrestha/Python Projects/blog/venv/lib/python3.8/site-packages/masonite/autoload.py", line 49, in load
    self._get_module_members(module_loader, name)
  File "/Users/yubarajshrestha/Python Projects/blog/venv/lib/python3.8/site-packages/masonite/autoload.py", line 173, in _get_module_members
    return importlib.import_module(
  File "/usr/local/Cellar/python@3.8/3.8.10/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/__init__.py", line 122, in import_module
    raise TypeError(msg.format(name))
TypeError: the 'package' argument is required to perform a relative import for '.Users.yubarajshrestha.Python Projects.blog.app.User'

Desktop (please complete the following information):

• OS: Mac

Additional context
Python Version: 3.8.10
M3 (Masonite v3)

[girardinsamuel]

What happen if you remove the space in the folder (Python Projects) ?

What happen if you remove the space in the folder (Python Projects) ?

It was working before, I updated the system this morning and also homebrew, now I encountered this issue.

[girardinsamuel]

Oh okay, I will test with 3.8.10 then

Oh okay, I will test with 3.8.10 then

Thanks, the system was perfectly working. I think the issue is with 3.8.10.

[girardinsamuel]

Yes 3.8.10 or 3.9.5 which are the latest Python 3 releases from May 3rd.
It has not made its way into pyenv so I was not able to test them with it, I will directly try by installing from python.org

[girardinsamuel]

I reproduced the problem locally. I'll try to fix it

I reproduced the problem locally. I'll try to fix it

So this is an issue with 3.8.10.

[girardinsamuel]

I guess the issue might happen with 3.9.5 too. No issue with 3.9.4.

[girardinsamuel]

importlib.import_module has not changed between those releases, so this is due a side-effect somewhere else.
I will look closely at the release log

[girardinsamuel]

It's because of pkgutil module

Tested in a local masonite project :

3.8.10

import pkgutil
for module_loader, name, _ in pkgutil.iter_modules(["app"]):
    print(module_loader, name)

FileFinder('/Users/samuel/repos/masonite/tests/new_3.8.10/app') User

3.8.9:

import pkgutil
for module_loader, name, _ in pkgutil.iter_modules(["app"]):
    print(module_loader, name)

FileFinder('app') User

Path is not relative to the current working directory anymore

The detailed changelog of 3.8.10 is here https://docs.python.org/release/3.8.10/whatsnew/changelog.html
I am looking into pkgutil and importlib related changes

Looks like it could be due to : Importlib now resolves relative paths when creating module spec objects from file locations

Related Bug report: https://bugs.python.org/issue43105
PR: python/cpython#25121
Line in the PR where absolute path is built :
python/cpython@0af99b4#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4R723

[girardinsamuel]

@meyubaraj
(can test with pip install git+https://github.com/girardinsamuel/masonite.git@fix/435)
@josephmancuso Here is a PR which seems to fix this behaviour. I am not sure if's the way to go but that works.

pip install git+https://github.com/girardinsamuel/masonite.git@fix/435

Not working!