Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added explicit type casting for route parameters #639

Merged
merged 1 commit into from
May 27, 2022
Merged

Added explicit type casting for route parameters #639

merged 1 commit into from
May 27, 2022

Conversation

girardinsamuel
Copy link
Contributor

Fix #635.

@girardinsamuel girardinsamuel added the Next Minor Non-breaking change that can go into the next minor version label May 22, 2022
josephmancuso
josephmancuso approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@josephmancuso josephmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review looks good

@josephmancuso
Copy link
Member

Is there anything else? I think that's it right?

@girardinsamuel
Copy link
Contributor Author

I think too 😅

@josephmancuso josephmancuso merged commit c438617 into MasoniteFramework:4.0 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso josephmancuso approved these changes

Assignees
No one assigned
Labels
Next Minor Non-breaking change that can go into the next minor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explicit type casting for route parameters
2 participants
@girardinsamuel @josephmancuso