Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/redis cache issues #811

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

circulon
Copy link
Contributor

Refactored Redis Cache Driver

  • Fixed internal cache not always loaded on first cache access
  • added ability to define “timeout” for for key expiry
    • defaults to a ttl of 1 month.
    • Previous hardcoded value was 10 years!
  • correctly store and unpack int types
  • fix internal cache not removed if store was flushed
  • fixed an issue where an imternal cache key would not be updated if it existed, but would be updated in the Redis store
  • added expiring of internal cache keys

circulon added 5 commits July 24, 2024 14:38
Refactored Redis Cache Driver
- Fixed internal cache not always loaded on first cace access
- added ability to define “timeout” for for item expiry
- - defaults to 1 month.  Previous hardcoded value was 10 years
- correctly store and unpack int types
- fix internal cache not removed if store was flushed
- fixed an issue where am imternal cache key would not be updated if it existed, but would be updated in the Redis store
Redis has no way to get key ttl enmasse to we oft for an on demand check and update the internal cache as required
@circulon
Copy link
Contributor Author

@goophps
As you are using Redis would you have a look at this for a second opinion please?

@josephmancuso josephmancuso merged commit 77a5499 into MasoniteFramework:4.0 Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants