Fix session errors and View errors() helper always empty #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the errors key back into the session flash. Changed the View errors helper name from ‘bag’ back to ‘errors’
Other modules will probably not expect a MessageBag as the content of the session ‘errors’ key. So just pass it through
|
@josephmancuso Looks like this issue has been hiding since v4.16.4 around commit 594d50b |
|
@josephmancuso @eaguad1337 Cheers |
|
@josephmancuso LGTM please and tagged This is impacting multiple areas of development. Cheers |
|
this is actually a pretty smart solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@josephmancuso
Sorry I broke this PR badly and had to recreate it so we have lost the chat history ;(.
This PR addresses #816:
One thing I would ask is:
Happy to discuss
will add Tests for SessionMiddleware soon