Skip to content

Warnings throwing on WC_Gateway_Simplify_Commerce_Loader::__wakeup(). #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtsiakiris
Copy link

Endless warning messages show up in error log file while running on PHP 8.

The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in ../wp-content/plugins/woocommerce-simplify-payment-gateway-plugin-2.2.0/woocommerce-simplify-payment-gateway.php on line 71.

Warnings goes away when set to public. Please check this, as in cases of high traffic, error logs is on fire.
Although this is a minor lets say warning, it doesn't mean nobody has to deal with this, right?

Endless warning messages show up in error log file while running on PHP 8.

The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in ../wp-content/plugins/woocommerce-simplify-payment-gateway-plugin-2.2.0/woocommerce-simplify-payment-gateway.php on line 71.

Warnings goes away when set to public. Please check this, as in cases of high traffic, error logs is on fire.
Although this is a minor lets say warning, it doesn't mean nobody has to deal with this, right?
@Bartosz-AU
Copy link

PHP 7.4 has now reached end of life support and PHP 8.0 is now the minimum supported release - please merge 2.3.2 with this commit to fix error for public visibility. There are also some other errors when using PHP 8.0 not addressed yet:

Warning: The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in /home/.../public_html/wp-content/plugins/simplifycommerce/woocommerce-simplify-payment-gateway.php on line 72

Deprecated: Required parameter $args follows optional parameter $authentication in /home/.../public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268

Deprecated: Required parameter $expectedArgCount follows optional parameter $authentication in /home/.../public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants