New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflecting the case-insensitivity of http headers #275

Merged

therealryan merged 2 commits into main from header_case

Mar 3, 2023

Contributor

therealryan commented Feb 27, 2023 •

edited

Loading

I recently went on a really unfun yak-shaving expedition when I:

Added an endpoint that uses the PATCH http method
Added a flow that exercised it
Discovered that the standard java HttpURLConnection stuff just doesn't support that
Refactored to use the new HTTPClient stuff in java 11
Found that HTTPHeaders only reports lower-case header names, even though we're confident that the service returns mixed-case. This broke the chunked transfer-encoding stuff that the HttpMsg types do, and required a bunch of tedious test-data updates.

HTTPHeaders's casing behaviour is the correct position, so we're going to adapt to that.


          reflecting the case-insensitivity of http headers

2d76783

therealryan assigned apanayotopoulos and pratyp

therealryan commented

View reviewed changes

message/message-http/src/main/java/com/mastercard/test/flow/msg/http/HttpMsg.java Show resolved Hide resolved


          Merge branch 'main' into header_case

6bf2cfa

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

therealryan commented

View reviewed changes

message/message-http/src/main/java/com/mastercard/test/flow/msg/http/HttpReq.java Show resolved Hide resolved

therealryan assigned qianliok

apanayotopoulos approved these changes

View reviewed changes

apanayotopoulos left a comment

Looks pretty straightforward to me

oconnord approved these changes

View reviewed changes

oconnord left a comment

Happy with these changes.

pratyp approved these changes

View reviewed changes

therealryan linked an issue

that may be closed by this pull request

HTTP header case sensitivity #260

Closed

therealryan merged commit c27e201 into main

therealryan deleted the header_case branch

March 3, 2023 09:02

therealryan added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels