Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be really bad if mutable fields are added to messages - if those values can get updated independently of the message you're left trying to find out why your message has changed when nothing is touching the message itself. It's a painful problem to debug.
Hence the message types are quite strict about what value types can be added - by default they only accept types that we know are immutable.
I've recently butted up against this limitation:
java.util.UUID
values (the type is immutable)java.sql.Timestamp
values (this type is mutable, but it would be really convenient to use it directly)This change:
UUID
to the set of immutable types