Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property test #306

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Property test #306

merged 2 commits into from
Mar 22, 2023

Conversation

therealryan
Copy link
Contributor

Closing #259.

We're also taking the opportunity to address a wee API niggle in the Model interface:

  • Adding a submodel class to a LazyModel instance by calling the with( class ) method is something you'll do all the time.
  • Adding a listener to the model with the withListener( listener ) method is something you'll do maybe once, if you have a really complex model that you need to instrument.

Hence it's really annoying when your IDE offers withListener before with when you autocomplete on .w.
To resolve this we've renamed withListener()

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@therealryan therealryan merged commit 6049fa0 into main Mar 22, 2023
@therealryan therealryan deleted the property_test branch March 22, 2023 11:51
@therealryan therealryan linked an issue Mar 24, 2023 that may be closed by this pull request
Documented property correctness #259
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documented property correctness
1 participant
@therealryan