Semantic diffs aren't very helpful for us #435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use diff-match-patch in the report app for three things:
For the first of these usages we saw that the diff_cleanupSemantic wasn't actually very helpful for the sort of text that we were working with, so we left it out.
That method was already being called for the other two usages - this change removes those calls so that all diff operations are consistent.
In the process of this change we noticed that: