Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up angular build config #616

Merged
merged 1 commit into from
Nov 3, 2023
Merged

clean up angular build config #616

merged 1 commit into from
Nov 3, 2023

Conversation

thomaslantern
Copy link
Contributor

  • Deleted build-all scripts entry (this used to build both apps)
  • The two places in the pom file where build-all is invoked now invoke build instead

@therealryan
Copy link
Contributor

This resolves #614. The sonar and result publish actions are failing, but that's probably just some tedious permissions issue. I'll confirm that and merge in the morning.

Cheers!

@therealryan therealryan linked an issue Nov 3, 2023 that may be closed by this pull request
Clean up angular build config #614
Closed
@therealryan therealryan merged commit 9cd4afb into Mastercard:main Nov 3, 2023
5 of 8 checks passed
@therealryan
Copy link
Contributor

@thomaslantern thanks for your contribution!

@thomaslantern
Copy link
Contributor Author

@therealryan my pleasure! Happy to contribute.

@therealryan therealryan added the javascript Pull requests that update Javascript code label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up angular build config
2 participants
@thomaslantern @therealryan