Glide fails to detect some dependencies

[aeneasr]

I have two packages in one directory. One is ladon and one is ladon_test. When running glide init or glide up, dependencies from the ladon_test do not show up in glide.yaml nor in glide.lock nor in the vendor directory. I am using glide version 0.11.0-dev.

[aeneasr]

glide list gives me:

INSTALLED packages:
        github.com/Sirupsen/logrus
        github.com/cenk/backoff
        github.com/davecgh/go-spew/spew
        github.com/go-errors/errors
        github.com/golang/mock/gomock
        github.com/golang/protobuf/proto
        github.com/hailocab/go-hostpool
        github.com/oleiade/reflections
        github.com/ory-am/common/compiler
        github.com/ory-am/common/pkg
        github.com/pmezard/go-difflib/difflib
        github.com/stretchr/testify/assert
        github.com/stretchr/testify/require
        golang.org/x/crypto/pbkdf2
        golang.org/x/net/context
        golang.org/x/sys/unix
        gopkg.in/dancannon/gorethink.v2
        gopkg.in/dancannon/gorethink.v2/encoding
        gopkg.in/dancannon/gorethink.v2/ql2
        gopkg.in/dancannon/gorethink.v2/types
        gopkg.in/fatih/pool.v2

[aeneasr]

When renaming ladon_test to ladon, everything works as expected.

[aeneasr]

Having packages like ladon_test around is quite important because it avoids import cycles when writing tests:

• package a
• package b imports package a
• package a_test imports package b

additionally, foo_test isn't a package you can import which makes sense to keep all Test* functions out of autocomplete.

[mattfarina]

@arekkas glide does handle tests. It seems you're using a dev version rather than a release. When is this dev version from? Can you try a release version?

[aeneasr]

i update glide using go get -u github.com/masterminds/glide

[aeneasr]

let me clarify, it is not about foobar_test.go, it's about naming a package package foobar_test instead of package foobar

[aeneasr]

Running

$ cd $GOPATH/src/github.com/Masterminds/glide
$ git checkout v0.11.1
$ go install .
$ which glide
/Users/aeneas/workspaces/go/bin/glide
$ cd other_go_project

$ glide install / up / init

yields the same outcome.

[mattfarina]

@arekkas so, you have two packages with different names in the same directory? Is that the issue?

That should work as well. If that is the case we'll need to look into that.

[aeneasr]

@arekkas so, you have two packages with different names in the same directory? Is that the issue?

exactly, see OP:

I have two packages in one directory. One is ladon and one is ladon_test.

[aeneasr]

It doesn't seem to be linked solely to having two packages in the same directory. For example: https://github.com/ory-am/fosite/blob/master/integration/helper_setup_test.go#L8

Directory /integration knows only package integration_test and is importing as the only package github.com/gorilla/mux and gorilla/mux is missing in glide.yaml/glide.lock. You can probably reproduce this by doing:

$ go get -d github.com/ory-am/fosite
$ cd $GOPATH/src/github.com/ory-am/fosite
$ rm glide.*
$ glide create
$ glide up
$ cat glide.yaml | grep mux
# should be empty
$ cat glide.lock | grep mux
# should be empty

[aeneasr]

This problem is annoying because you find the missing dependencies only on a clean GOPATH, which happens most likely on your CI system, which then again takes 5-10 minutes to run.

[sdboyer]

seems like the issue arises specifically when relying on the package <pkg>_test idiom? i have a feeling i might know where the issue is...

Ah, yep. The current resolver only reads build.Package.TestImports, but does not include build.Package.XTestImports. Imports from the secondary test package are kept in the latter property.

[aeneasr]

Thanks for tracing this, unfortunately I have no idea how to fix this, so it's probably better if somebody else takes a shot at it

[sdboyer]

yep, i got it