Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework create/init #444

Merged
merged 13 commits into from
Jun 6, 2016
Merged

Rework create/init #444

merged 13 commits into from
Jun 6, 2016

Conversation

mattfarina
Copy link
Member

No description provided.

- Attempts to detect tagged versions
- Leverages the cache
- Output provides more detail about what's happening
@mattfarina mattfarina added this to the 0.11 milestone May 25, 2016
@mattfarina
Copy link
Member Author

@thockin @technosophos I'd be really curious to know what you think about this? It's a big change designed to be helpful when setting up a project to use Glide.

@thockin
Copy link
Contributor

thockin commented May 27, 2016

Can you summarize the change? I'm not equipped for this as a code review.

@mattfarina
Copy link
Member Author

@thockin Rather than a code review I'd be curious as a user usage review. So, grab the code, install it, and try glide init on a project. Particularly one that imports from Godep.

@thockin
Copy link
Contributor

thockin commented May 27, 2016

Can you summarize? I'm beyond buried at the moment, and coming up on a
vacation. If you want feedback before July...

On Fri, May 27, 2016 at 10:33 AM, Matt Farina notifications@github.com
wrote:

@thockin https://github.com/thockin Rather than a code review I'd be
curious as a user usage review. So, grab the code, install it, and try glide
init on a project. Particularly one that imports from Godep.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#444 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFVgVB1TKcoE9BzUiyn_zkWhDVg9k1vhks5qFyr_gaJpZM4ImvOk
.

@mattfarina
Copy link
Member Author

@thockin if you're buried and coming up on a vacation don't feel pressure to review.

This turns glide init into a wizard. It will try to detect versions from commit ids, try to offer release versions if nothing is detected, and help you setup using ranges for projects that use releases. It's a start and i'm curious on the wizard interaction model.

And, it's interactive. For example, if a project uses semver your choice for ranges may be to follow patch or minor releases.

@thockin
Copy link
Contributor

thockin commented May 27, 2016

That's interesting! I think I would want first to do a transliteration -
don't change ANYTHING. Let me convince myself it compiles and works.
Commit that. Then I might want to optimize more (e.g. using tags instead
of hashes, or ranges)

On Fri, May 27, 2016 at 12:01 PM, Matt Farina notifications@github.com
wrote:

@thockin https://github.com/thockin if you're buried and coming up on a
vacation don't feel pressure to review.

This turns glide init into a wizard. It will try to detect versions from
commit ids, try to offer release versions if nothing is detected, and help
you setup using ranges for projects that use releases. It's a start and i'm
curious on the wizard interaction model.

And, it's interactive. For example, if a project uses semver your choice
for ranges may be to follow patch or minor releases.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#444 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFVgVNXWCi83RM1_rB1PMul7pYvjBa-Bks5qFz-WgaJpZM4ImvOk
.

@mattfarina
Copy link
Member Author

@thockin That alone is fantastic feedback. This is the kind of thing I was looking for.

@thockin
Copy link
Contributor

thockin commented May 27, 2016

Always ask "what would a paranoid person who has been repeatedly burned by
trusting ANYONE want?". That's me. :)

On Fri, May 27, 2016 at 12:40 PM, Matt Farina notifications@github.com
wrote:

@thockin https://github.com/thockin That alone is fantastic feedback.
This is the kind of thing I was looking for.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#444 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFVgVB78h8ejFwVsoldSUeqT3UGX9MDWks5qF0iRgaJpZM4ImvOk
.

@sdboyer
Copy link
Member

sdboyer commented May 28, 2016

Always ask "what would a paranoid person who has been repeatedly burned by
trusting ANYONE want?". That's me. :)

this calls to mind a reddit conversation we had :)

@mattfarina
Copy link
Member Author

@technosophos and anyone else... I would love feedback on this new version. Less intrusive and you can use the wizard later.

@technosophos
Copy link
Member

technosophos commented Jun 3, 2016

🚢 I like it.

Tested on Kubernetes Helm.

@mattfarina mattfarina merged commit 9efca87 into master Jun 6, 2016
@mattfarina mattfarina deleted the feat/reworked-init branch June 6, 2016 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants