Glide install skips fetch when it is up to date #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 'glide install', this lazily computes whether the existing vendor checkouts are already at the right commit. If they are, those deps are skipped during the concurrent update. This is safe to do in install because the dependency graph is already computed, so there should never be a case where the glide.lock file does not contain a negotiable dependency graph.
technosophos
force-pushed
the
feat/lazy-concurrent-update-on-install
branch
from
de28cf5
to
6a3ace6
Compare
| @@ -302,6 +302,43 @@ func (i *Installer) List(conf *cfg.Config) []*cfg.Dependency { | |||
| return conf.Imports | |||
| } | |||
|
|
|||
| // LazyConcurrentUpdate updates only deps that are not already checkout out at the right version. | |||
There was a problem hiding this comment.
ahh, saw this too late - s/checkout out/checked out/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 'glide install', this lazily computes whether the existing vendor
checkouts are already at the right commit. If they are, those deps are
skipped during the concurrent update.
This is safe to do in install because the dependency graph is already
computed, so there should never be a case where the glide.lock file does
not contain a negotiable dependency graph.