Fixed #778: Removing and moving large sets of files fails on Windows #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an example of the issue and status on Go itself see golang/go#20841 When working with large file sets such as those in a large dependency tree (e.g. thousands of files) functions such as os.RemoveAll and os.Rename can fail on Windows and Windows Subsystem for Linux. The system commands work without issue. This change detects Windows and the WSL environments then drops down to system commands to make these changes. On mac, linux, and other the os package functions are still used.
|
It works for me on Windows Subsytem for Linux. I was never able to reproduce on Windows proper so somebody else will have to try that. |
|
It works for me on Windows proper 🎆. Have given this only one shot - but it worked without any error, whereas the glide.exe taken from releases didn't. I'll give it more tries later tomorrow. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of the issue and status on Go itself see
golang/go#20841
When working with large file sets such as those in a large dependency
tree (e.g. thousands of files) functions such as os.RemoveAll and
os.Rename can fail on Windows and Windows Subsystem for Linux. The
system commands work without issue.
This change detects Windows and the WSL environments then drops
down to system commands to make these changes. On mac, linux, and
other the os package functions are still used.