Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for s390x #870

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Conversation

Nayana-ibm
Copy link
Contributor

Added support for linux/s390x arch in glide.
Please review.

@Nayana-ibm
Copy link
Contributor Author

Along with this PR, we also require to add code in gox to support s390x.
Below diff will be required in https://github.com/franciscocpg/gox repo.

diff --git a/platform.go b/platform.go
index 9353b09..50820a5 100644
--- a/platform.go
+++ b/platform.go
@@ -73,6 +73,7 @@ var (
                "mips64le",
                "ppc64",
                "ppc64le",
+               "s390x",
        }

        Platforms_1_0 = []Platform{
@@ -123,7 +124,10 @@ var (
        }...)

        // Nothing changed from 1.5 to 1.6
-       Platforms_1_6 = Platforms_1_5
+       // Support for s390x
+       Platforms_1_6 = append(Platforms_1_5, []Platform{
+                {OS: "linux", Arch: "s390x", Default: true},
+       }...)
 )

 // SupportedPlatforms returns the full list of supported platforms for

To contribute for that change, we want to know about Contributor License Agreement.
I have checked URL to License: https://github.com/franciscocpg/gox/blob/master/LICENSE and
https://github.com/mitchellh/gox/blob/master/LICENSE
Please let us know which Contributor License Agreement needs for gox .

@Nayana-ibm
Copy link
Contributor Author

@mattfarina @franciscocpg Could you please provide your inputs?

@franciscocpg
Copy link
Member

@Nayana-ibm, i don't think that @mitchellh has any plans for merging new incoming PRs for https://github.com/mitchellh/gox. The last commit was about 1 year ago.

I think it makes sense to do something like this.

@mattfarina
Copy link
Member

I'm going to take a look at gox vs the alternatives to see what is the best way. I'd like to cut a release soon and if there is something better now may be a good time to switch. Or, I'll look at the alternative @franciscocpg suggested.

If anyone knows of a good alternative to gox I'm interested in learning about it.

mattfarina added a commit to Masterminds/gox that referenced this pull request Sep 27, 2017
Go now supports the s390x architecture and glide has had a request
for builds in this platform. See
Masterminds/glide#870
@mattfarina mattfarina merged commit 80afe4d into Masterminds:master Sep 27, 2017
@mattfarina
Copy link
Member

I've created Masterminds/gox (based on the great work of @franciscocpg) and added support for s390x. In #916 I moved glide to use that for cross compiling. Along with this change we should now be able to produce an s390x binary.

@Nayana-ibm
Copy link
Contributor Author

Thanks @mattfarina It means Masterminds/gox will have s390x binaries/tar published on
https://github.com/Masterminds/glide/releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants