Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version info in lock file and export log #921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vearutop
Copy link

@vearutop vearutop commented Oct 2, 2017

This pull request aims to improve deps info redability in export log by adding commit info (including tag name if available)

[INFO]  Exporting resolved dependencies...
[INFO]  --> Exporting github.com/Masterminds/vcs v1.12.0@6f1c6d1 (^1.12.0) 2017-09-11 Matt Farina <matt@mattfarina.com>
[INFO]  --> Exporting github.com/codegangsta/cli v1.20.0@cfb3883 (^1.16.0) 2017-08-11 Jesse Szwedko <jesse.szwedko@gmail.com>
[INFO]  --> Exporting github.com/Masterminds/semver v1.3.1@517734c (^1.3.0) 2017-07-10 Matt Farina <matt@mattfarina.com>

Also in glide.lock file by adding brief commit info as yaml comment

hash: 9678e016890de949db9cfcae386b5ae1a4c2149ccd602aad33ac90d7c19d117e
updated: 2017-09-22T16:50:29.351652493+07:00
imports:
- name: github.com/codegangsta/cli
  version: cfb38830724cc34fedffe9a2a29fb54fa9169cd1 # v1.20.0, 2017-08-11
- name: github.com/Masterminds/semver
  version: 517734cc7d6470c0d07130e40fd40bdeb9bcd3fd # v1.3.1, 2017-07-10
- name: github.com/Masterminds/vcs
  version: 6f1c6d150500e452704e9863f68c2559f58616bf # v1.12.0, 2017-09-11
- name: github.com/mitchellh/go-homedir

@mattfarina
Copy link
Member

@vearutop Interesting idea. I had not thought of this but I kind of like it.

/cc @sdboyer your thoughts? I'm thinking if something like this would be interesting to dep. I would want a feature to land there before I add something to glide so the feature has a future.

@theo-schaeffer
Copy link

Very interesting idea, it would help us to easily compare deps versions in our different projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants