Implement encoding.TextMarshaler and encoding.TextUnmarshaler #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkRosemaker
changed the title
|
you need not to add the dependencies to the tree. that previous pr did similar, you could have a look #131 |
mh-cbon
reviewed
May 28, 2022
mh-cbon
reviewed
May 28, 2022
mh-cbon
approved these changes
Jun 1, 2022
|
Thanks for the review, @mh-cbon ! Can we merge this? |
|
What do you think, @mattfarina? Can we merge this? |
|
@mh-cbon @mattfarina What is the process to merge a PR? I can't seem to be able to merge this since I lack write access. |
piccobit
added a commit
to piccobit/semver
that referenced
this pull request
Jul 26, 2022
Merged PR Masterminds#173 of upstream repository
mattfarina
approved these changes
Nov 28, 2022
MarkRosemaker
deleted the
implement-encoding.TextMarshaler-and-encoding.TextUnmarshaler
branch
This was referenced Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements encoding.TextMarshaler and encoding.TextUnmarshaler for
semver.Version.This now allows marshalling and unmarshalling yaml, which was tested using three different yaml libraries.