Skip to content

Commit

Permalink
git: remove extra quotes in submodule export
Browse files Browse the repository at this point in the history
on the cli, one uses the extra single quotes to ensure the whole cmd is passed as a single arg despite
containing spaces, but when passing args in a structured call like this, it isn't needed.

Fixes Masterminds/glide#745
  • Loading branch information
dt committed Jan 21, 2017
1 parent bac0f48 commit 2449b6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git.go
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ func (s *GitRepo) ExportDir(dir string) error {
return NewLocalError("Unable to export source", err, string(out))
}
// and now, the horror of submodules
out, err = s.RunFromDir("git", "submodule", "foreach", "--recursive", "'git checkout-index -f -a --prefix=\""+filepath.Join(dir, "$path")+"\"'")
out, err = s.RunFromDir("git", "submodule", "foreach", "--recursive", "git checkout-index -f -a --prefix=\""+filepath.Join(dir, "$path")+"/\"")
s.log(out)
if err != nil {
return NewLocalError("Error while exporting submodule sources", err, string(out))
Expand Down

0 comments on commit 2449b6d

Please sign in to comment.