Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for IE11 #107

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

gabskoro
Copy link
Contributor

I must admit that I can't remember when was the last time I had such a hard time fixing an issue 😅 The bundled code is fine, it just doesn't work on IE11 giving us a Syntax error in the console.

I noticed that you are using @babel/preset-env and therefore the arrow functions transform plugin is included as it also transpiled your code. The issue was that the bundled code was always exporting module.exports=(()=>... so after a while I finally managed to find out that, in the newer version of webpack (5) you should specify arrowFunction: false in the output.environment if you don't want them to use arrow functions. So, after adding that the bundled code starts now with module.exports=function(){...

https://webpack.js.org/configuration/output/#outputenvironment

Let me please know if you will need anything else from my side :)

@Mastermindzh
Copy link
Owner

Hey @gabskoro ,

PR looks good. I'll test, marge and release a version tonight.
Thanks for the contribution.

Shouldn't need anything else, you've been thorough and actually respected the contribution guidelines. Very nice!

@Mastermindzh Mastermindzh merged commit 0228e7f into Mastermindzh:master Feb 19, 2021
@Mastermindzh
Copy link
Owner

It has been released: 6.2.3

Thanks for the contribution!

@gabskoro gabskoro deleted the feat/ie11-support branch February 19, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants