9 animations #241
Merged
9 animations #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrovladyslav
requested changes
Dec 17, 2021
homeworks/oleksandr.prylutskiy_SanSandru4/8-css-variables/index.html
Outdated
Show resolved
Hide resolved
homeworks/oleksandr.prylutskiy_SanSandru4/8-css-variables/index.html
Outdated
Show resolved
Hide resolved
| @@ -12,6 +12,14 @@ | |||
| <title>Archmove</title> | |||
| </head> | |||
| <body> | |||
| <div class="preloader" data-preloader> | |||
| <div class="loader__spin"></div> | |||
There was a problem hiding this comment.
Если родительский блок называется preloader то и его дочерние элементы должны начинаться с такого же слова. Это создаёт одинаковое пространство имён
electrovladyslav
requested changes
Dec 19, 2021
| @@ -1,28 +0,0 @@ | |||
| const changeSkin = document.querySelector('[data-attr-change-skin]'); | |||
There was a problem hiding this comment.
Не не нужно в этом пулл реквесте удалять что-то из других папок.
Сделай так, чтобы этого удаления файла не было в этом пулл-реквесте
| @@ -12,6 +12,14 @@ | |||
| <title>Archmove</title> | |||
| </head> | |||
| <body> | |||
| <div class="preloader" data-preloader> | |||
| <div class="preloader__spin loader"></div> | |||
There was a problem hiding this comment.
Зачем ты добавил тут блок лоадер? Это отдельная сущность? Или это всё одна сущность прелоадер?
homeworks/oleksandr.prylutskiy_SanSandru4/9-animations/script.js
Outdated
Show resolved
Hide resolved
electrovladyslav
approved these changes
Dec 19, 2021
|
Супер! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.