Add Geometry@toSqlExpression method
#70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatanYadaev
requested changes
Dec 11, 2022
Owner
MatanYadaev
left a comment
MatanYadaev
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left a few comments.
MatanYadaev
requested changes
Dec 12, 2022
Co-authored-by: Matan Yadaev <matan.yed@gmail.com>
Co-authored-by: Matan Yadaev <matan.yed@gmail.com>
Co-authored-by: Matan Yadaev <matan.yed@gmail.com>
Co-authored-by: Matan Yadaev <matan.yed@gmail.com>
Contributor
Author
|
I've done all those (and it's much cleaner) - but I don't see why this merge conflict is happening when it's a straight addition |
MatanYadaev
approved these changes
Dec 12, 2022
Owner
|
@Synchro I updated the |
MatanYadaev
changed the title
Geometry@toSqlExpression method
Owner
|
@Synchro Fixed the conflicts. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a PR adding a method (with a test!) that generates an
Expressionthat can be used for manual casting along the lines of what I was asking in #69. I'm not sure about the name, or whether you think this is incomplete!