Add HasSpatial trait
#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatanYadaev
requested changes
Jan 5, 2023
Owner
MatanYadaev
left a comment
MatanYadaev
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left small comments.
MatanYadaev
changed the title
HasSpatial trait
- update readme instruction - restore phpdoc ide hint - trailing newline for phpcs
Contributor
Author
|
Very welcome - it's my first ever open-source contribution, so I'm glad you like it. Updates pushed. |
MatanYadaev
requested changes
Jan 7, 2023
Owner
MatanYadaev
left a comment
MatanYadaev
left a comment
There was a problem hiding this comment.
You have lint issues, please run composer run php-cs-fixer to fix these issues.
- typo & cs-fixer fix
MatanYadaev
approved these changes
Jan 9, 2023
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - I made this small change locally to be more "the laravel way" and thought I'd share.