-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab control extended #2544
Tab control extended #2544
Conversation
… format the document
i don't think removing |
This fixes #1616 |
great work so far, thank you |
I will be checking some placement bugs in coming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice. Let me know when it is ready to merge.
|
||
namespace MaterialDesignThemes.Wpf | ||
{ | ||
public static class TabItemAssist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being used anywhere?
I can see the Leading/Top icon in the demo but I would expect that if someone wanted that look, they would simply put a StackPanel
inside of the TabItem.Header
and setup the layout that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't be used. I commited this a bit too soon, I'll remove the class in a following commit.
I was thinking this could be a preferred way of doing this, analogous with how Button has a LeadingIcon.
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
I extended the work of ahmed-abdelrazek (#2542).
It fixes following things:
Foreground color of context inside TabItem
Better UI on the demo page
Replaced the default TabItem style with the compact one, removing the compact style in the process
Adding a shadow per Material spec guidelines
Removed the
SmallCaps
property for TabItem headersWIP: TopIcon implementation
WIP: making the control independent of ColorZone