Cleanup: Aligning hint, helper text and validation error based on padding #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper text and the validation error now respects a custom padding
nicolaihenriksen
added
the
visual breaking change
Keboo
added
the
release notes
Keboo
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the styles utilizing the
SmartHintbecause there are several scenarios where the helper text and validation error do not align properly when a non-defaultTextBox.Paddingis set.I updated the SmartHint demo app page to enable applying custom padding and toggling
Validation.HasErroron/off. This is a quick way to visually see if things are as you'd expect.I wrote some UI tests to ensure the alignments are correct. Well almost, currently within accepted tolerance. Follow up PRs (see below) should hopefully remove this tolerance.
Fixed for the following controls:
Removed the wrong usages of
TextFieldAssist.TextBoxViewMarginin the templates above.There are still some minor misalignments between the hint, helper text, validation text and the actual control text content that should be taken care of; this will come in other PRs.