NEW FEATURE: Multi-select TreeView #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling left/right arrow keys
This is a first approach at dealing with the issue of taking expanded children (and grand-children) into account when determining an offset into the InternalItemsSource.
I also split up the move tests into move up and down variants. It is only the tests with expanded children that fail.
It wrongfully removed the whole item. Now it only removes the children/grand-children.
Since children get disconnected when moving the parent item this is a (hopefully temporary) workaround which simply collapses all children of the parent and its siblings before moving around in the collection. This is really not ideal behavior, and we should try to get it to work correctly. I have left code in here which attempts to get it to work correctly, but it is not working yet.
Also removed failed attempt at disconnecting items.
This (hacky) fix allows moving items (and their children) by determining their state before the move, and then restoring that state after the move.
"Fixed" by delegating the responsibility of the move operation out to the TreeListView which has a concept of containers. This allows us to reuse the Collapse->Move->Expand approach which is used when moving nested items around.
Does this work? Fixing event leaks We can collapse.... but this seems like cheating.
Better implementation that doesn't provoke the disconnected item. Fixed cleanup issues with the containers. All tests are passing :)
I may be wrong here, but I believe the <VisualState> storyboards should not have a duration. I believe these will be invoked when VisualStateManager.GoToState() is called with useTransitions=false. Thus I believe animations (durations) should only be used in the <VisualTransistion> storyboards which is invoked when VisualStateManager.GoToState() is called with useTransitions=true.
Fixed issue with replacing the last item. Added additional replacement tests
Keboo
force-pushed
the
multiSelectTreeView
branch
from
e303dc1 to
bc52078
Compare
Keboo
added
enhancement
release notes
|
does it work well with virtualization? |
Yea, because it is just a list view, as long as it has virtualization enabled it works well for that. |
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This control is based on a ListView NOT a TreeView.
The interaction is expected to be similar to a TreeView with a HierarchialDataTemplate, but the rest of the UI should match ListView behavior.
At present there is no support for ListView.GridView.