Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Issues #3476 #3478 #3479 #3477

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fixing Issues #3476 #3478 #3479 #3477

merged 1 commit into from
Mar 7, 2024

Conversation

AbderrahmaneAhmam
Copy link
Contributor

@AbderrahmaneAhmam AbderrahmaneAhmam commented Mar 6, 2024 •
edited by nicolaihenriksen
Loading

Fixes #3476
Fixes #3478
Fixes #3479

Hello,

I have been working on issue #3476, #3478, #3479 and have successfully fixed it. However, during testing, I discovered additional issues, so I proceeded to address them:

  • Fixed a styling issue on the Fields page:
image
  • Addressed an issue with the DropDownList background color not being dynamic. I implemented a solution to use dynamic colors to resolve this issue:
  1. Issue
image
  1. Correction
image
  • Fixed an issue where item selection didn't work when there was only one suggested item.

Here are demos illustrating the defects and their corrections:
Demo of defects

Untitled.video.-.Made.with.Clipchamp.mp4

Demo of corrections

Untitled.video.-.Made.with.Clipchamp.1.mp4

@AbderrahmaneAhmam
Fixing Issues MaterialDesignInXAML#3476:
526259d 
- Corrected the styling of the outlined AutoSuggestBox on the Fields page.
- Resolved an issue where selecting an element was problematic when there was only one suggestion available.
- Adjusted the dynamic setting of the DropDownBox background to ensure compatibility with theme changes during live updates.
@AbderrahmaneAhmam AbderrahmaneAhmam changed the title Fixing Issues #3476 Fixing Issues #3476 #3478 Mar 6, 2024
@AbderrahmaneAhmam AbderrahmaneAhmam changed the title Fixing Issues #3476 #3478 Fixing Issues #3476 #3478 #3479 Mar 6, 2024
@Keboo Keboo added this to the 5.1.0 milestone Mar 7, 2024
@Keboo Keboo added the release notes Items are likely to be highlighted in the release notes. label Mar 7, 2024
@Keboo Keboo merged commit 0e2e2eb into MaterialDesignInXAML:master Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keboo Keboo Keboo approved these changes

Assignees
No one assigned
Labels
release notes Items are likely to be highlighted in the release notes.
Projects
None yet
Milestone
5.1.0
2 participants
@AbderrahmaneAhmam @Keboo