Skip to content

Set SmartHint.IsContentNullOrEmpty on initial load #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

Set SmartHint.IsContentNullOrEmpty on initial load #3915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
687e39a
update SmartHint.IsContentNullOrEmpty on initial load
corvinsz Sep 4, 2025
eb47880
added test case
corvinsz Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/MaterialDesignThemes.Wpf/SmartHint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ private void RefreshState(bool useTransitions)
if (proxy is null) return;
if (!proxy.IsVisible) return;

IsContentNullOrEmpty = proxy.IsEmpty();

var action = new Action(() =>
{
string state = string.Empty;
Expand Down
27 changes: 27 additions & 0 deletions tests/MaterialDesignThemes.UITests/WPF/TextBoxes/TextBoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,33 @@ await Wait.For(async() =>

recorder.Success();
}

[Test]
[Description("Issue 3914")]
public async Task TextBox_ClearButtonRemainsHidden_WhenInitiallyCollapsedAndMadeVisible()
{
await using var recorder = new TestRecorder(App);

var grid = await LoadXaml<Grid>($"""
<Grid Margin="30">
<TextBox Visibility="Collapsed"
VerticalAlignment="Center"
materialDesign:TextFieldAssist.HasClearButton="True">
</TextBox>
</Grid>
""");

var textBox = await grid.GetElement<TextBox>("/TextBox");

await textBox.SetVisibility(Visibility.Visible);

var clearButton = await grid.GetElement<Button>("PART_ClearButton");
Visibility clearButtonVisibility = await clearButton.GetVisibility();

await Assert.That(clearButtonVisibility).IsEqualTo(Visibility.Collapsed);

recorder.Success();
}
}

public class NotEmptyValidationRule : ValidationRule
Expand Down
Loading