Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube, kube-runtime, and k8s-openapi. Release version 0.2.0 due to compat change #9

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Aug 9, 2023

Upgrade to kube packages corresponding with PR in MZ repo MaterializeInc/materialize#21034 and soon to cloud repo.

This requires a compatibility break because of one upstream in kube-rs so I've bumped this package to version 0.2.0.

Supersedes #7 #8 #6

@rjobanp
Copy link
Contributor Author

rjobanp commented Aug 9, 2023

Also it looks like the deny check introduced here b27145a is failing with:

Run actions-rs/cargo@v1
/home/runner/.cargo/bin/cargo deny check
error: no such command: `deny`
Error: no such command: `deny`
	Did you mean `bench`?

edit: fixed by using the correct github action for cargo-deny

@rjobanp rjobanp force-pushed the roshan/update-kube-0.85 branch from 031b59f to de9f1e1 Compare August 9, 2023 15:15
Cargo.toml Outdated Show resolved Hide resolved
@rjobanp rjobanp force-pushed the roshan/update-kube-0.85 branch 2 times, most recently from a7ca393 to 2be839f Compare August 9, 2023 20:25
Copy link
Collaborator

@doy-materialize doy-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks fine - in particular, adding the packages to deny.toml here is basically required because the kube crates themselves also have these same things in their deny.toml, so i don't think there's currently a way to avoid it if we're using those crates.

@rjobanp rjobanp force-pushed the roshan/update-kube-0.85 branch from 2be839f to 023a8bf Compare August 10, 2023 18:07
@rjobanp rjobanp force-pushed the roshan/update-kube-0.85 branch from 023a8bf to 491b9b8 Compare August 10, 2023 18:11
@rjobanp rjobanp merged commit 689ddd0 into main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants