-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[coord] New secret guarantees #12334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @benesch , secrets will be the first thing to test once we have a kubernetes-enabled testing framework.
thank you @philip-stoev. Looking forward to it. |
adding @alex-hunt-materialize for FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks about right to me, but would be good to get Alex's eyes on the secret pod update too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
We have decided to move the creation of the secret into the environment controller in Kubernetes. When using the Kubernetes environment, all scripts have to create a new
user-managed-secrets
secret, if they desire to use the Kubernetes controller.The KubernetesSecretsController now waits until the secret becomes visible on its local filesystem. When altering secrets, we do not guarantee that the new secret content has been propagated.
Motivation
This PR adds a known-desirable feature.
Testing
Tested manually. Here are the current execution times on a default Kubernetes installation: