Skip to content

adapter: fix TODO, add Timestamp::from_duration #17459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023
Merged

adapter: fix TODO, add Timestamp::from_duration #17459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6defb23
branch start, update comment to include unstable features that we're …
ParkMyCar Feb 1, 2023
6648d50
cargo fmt
ParkMyCar Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/adapter/src/coord.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,13 @@ mod read_policy;
mod sequencer;
mod sql;

// TODO: We can have only two consts here, instead of three,
// once there exists a `const` way to convert between a `Timestamp`
// and a `Duration`
// TODO: We can have only two consts here, instead of three, once there exists a `const` way to
// convert between a `Timestamp` and a `Duration`, and unwrap a result in const contexts. Currently
// unstable compiler features that would allow this are:
// * `const_option`: https://github.com/rust-lang/rust/issues/67441
// * `const_result`: https://github.com/rust-lang/rust/issues/82814
// * `const_num_from_num`: https://github.com/rust-lang/rust/issues/87852
// * `const_precise_live_drops`: https://github.com/rust-lang/rust/issues/73255

/// `DEFAULT_LOGICAL_COMPACTION_WINDOW`, in milliseconds.
/// The default is set to a second to track the default timestamp frequency for sources.
Expand Down