Skip to content

CI: ignore await keyword in coverage #22111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nrainer-materialize
Copy link
Contributor

await is not properly supported.

See: rust-lang/rust#98712

@nrainer-materialize nrainer-materialize added the T-testing Theme: tests or test infrastructure label Oct 2, 2023
@nrainer-materialize nrainer-materialize self-assigned this Oct 2, 2023
IGNORE_RE = re.compile(
r"""
( \#\[derive\(.*\)\]
| \#\[mz_ore::test.*\]
| \s*\.await[?]?;?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just \.await?

Copy link
Contributor Author

@nrainer-materialize nrainer-materialize Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. (I had thought for whatever reason that I have to match the whole line.)

✅ Adjusted.

@nrainer-materialize nrainer-materialize merged commit 34125f2 into MaterializeInc:main Oct 3, 2023
@nrainer-materialize nrainer-materialize deleted the ci/coverage-ignores branch October 3, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-testing Theme: tests or test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants