Bump Rust version to 1.74.1 #25331
Merged
Bump Rust version to 1.74.1 #25331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
approved these changes
Feb 16, 2024
nrainer-materialize
approved these changes
Feb 16, 2024
|
Disabling auto-merge because of @ParkMyCar's comment. |
def-
force-pushed
the
pr-rust-1.76.0
branch
2 times, most recently
from
a85b6aa
to
9ec7bba
Compare
nrainer-materialize
approved these changes
Feb 19, 2024
def-
force-pushed
the
pr-rust-1.76.0
branch
6 times, most recently
from
2e6a9ed
to
92e2200
Compare
benesch
approved these changes
Feb 19, 2024
Unless I'm missing it this could still use a bump. I think it's fine to defer that bump until the 1.76 bump though. |
|
Indeed. I tried bumping the nightly version but that failed because of various reasons, so I tried a few versions inbetween, but they all fail for some reasons. Fixing the newest version will require a new version of nextest to be released, so I didn't want to block this since rustc is still panicking and making CI slightly annoying. |
|
Yup makes sense! Removing the ARM segfaults seems more important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/MaterializeInc/database-issues/issues/7406
Release notes: https://releases.rs/docs/1.74.1/
The fix we need for aarch64 compilation is rust-lang/rust#118464
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.