adapter: support mock LaunchDarkly connection #25946
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpret values of
launchdarkly-sdk-key
/MZ_LAUNCHDARKLY_SDK_KEY
that can be parsed as a socket address as an indication to configure LaunchDarkly to work against a polling address sitting behindhttp://{url}/polling
.This can be used to provide overrides in CI tests without depending directly on LaunchDarkly. Note that hopefully at some point the Rust SDK will catch up with other languages and we will be able to use this feature and won't need to run a mock LD server process.
Motivation
Exploring another solution of #25924
Tips for reviewer
To test this, first start a mock LaunchDarkly server (1):
and then
environmentd
with a customMZ_LAUNCHDARKLY_SDK_KEY
(2)If there is an easy way to make (1) available to (2) in
mzcompose
I think we could fix the issue described in #25924 with a more general, single*.py
extension in a single place.Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.