-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
balancerd: per-tenant metrics for http #25952
balancerd: per-tenant metrics for http #25952
Conversation
Will this capture webhook calls as well? |
Unfortunately, the SNI servername is not the tenant. The CNAME response to looking up that SNI servername does include the tenant ID, though. |
Yes! |
7ef8cf0
to
147fd1f
Compare
Lint is producing errors like
and uh I have no idea what to do about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
It seems that sysctl
is the thing pulling in the older enum-as-inner, and there is a newer v0.5.5 that uses the newer version. Perhaps upgrading to that would resolve the lint issues?
Oof, looks like it has other duplicates, which aren't so simple. |
Hickory DNS has idna 0.5 on their main branch. I'm not sure what to do about the quick-error thing, though, as |
I've opened hickory-dns/resolv-conf#35 to hopefully remove the dependency on quick-error in resolv-conf, but I doubt it will get merged any time soon. |
It seems like a pain, but a possible solution:
|
There are other ideas too like use the |
147fd1f
to
7184df8
Compare
cfa9a85
to
a8be561
Compare
Reworked to use the |
@alex-hunt-materialize the mzcompose tests do not test the CNAME -> tenant stuff because I don't know if docker compose can set up arbitrary CNAMES and didn't investigate that. After deploying this to staging we will need to do a few tests to make sure the http tenants are being correctly extracted. |
Use the CNAME to determine the tenant. Use the `domain` crate for CNAME lookup. This came with some new and updated imports. `cargo vet import` was re-ran for the 4 audit vendors we trust, yielding the cargo-vet changes to config.toml and imports.lock.
a8be561
to
62dfe8c
Compare
Extract the tenant from the CNAME.
Motivation
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.