-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
canary-cloud: Use Redpanda Cloud #29195
Conversation
ff31fce
to
579c2cb
Compare
2f70b17
to
6b0dfa5
Compare
c8bf04a
to
3457c38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic, @def-—thank you!
We can only run one cloud canary test with Redpanda Cloud at a time, right? Should we create a new pipeline ("Expensive nightly"? "External services nightly"?) so that folks using trigger-ci don't run this test when validating a PR?
This is already only executed on main and release branches, and also locked by using a concurrency group. So no problem for PRs. |
3d43a4d
to
d6c3792
Compare
Ah, beautiful! Well this basically LGTM. Are you still working to get it to pass nightlies? Let me know when you're ready for a full review (and how thorough of a review you feel you need). |
It worked before, I broke it again by some refactoring. Hopefully the new run is green now: https://buildkite.com/materialize/nightly/builds/9274 |
e265de5
to
cf57d50
Compare
3757a55
to
d2ab409
Compare
8fb3287
to
47e0e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic work, Dennis—thank you so much!
Fixes: https://github.com/MaterializeInc/cloud/issues/9721
Nightly run: https://buildkite.com/materialize/nightly/builds/9274
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.