Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/adapter: Introduce the Source References internal table, durably stored in the catalog #29208

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Aug 23, 2024

Motivation

Implements durable storage of 'source references' which will are used to populate the mz_internal.mz_source_references introspection table described here as part of the Source Versioning project: #27907

This doesn't actually implement the catalog operations to populate this table anywhere, but introduces all the boilerplate necessary to store this data in the catalog durably.

This is part of the work towards https://github.com/MaterializeInc/database-issues/issues/8376

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@rjobanp rjobanp requested review from petrosagg and removed request for petrosagg August 23, 2024 19:13
@rjobanp rjobanp force-pushed the source-references-catalog branch 4 times, most recently from 220b292 to a055e35 Compare August 27, 2024 14:04
@rjobanp rjobanp requested a review from jkosh44 August 27, 2024 14:08
@rjobanp rjobanp marked this pull request as ready for review August 27, 2024 14:08
@rjobanp rjobanp requested review from a team as code owners August 27, 2024 14:08
Copy link

shepherdlybot bot commented Aug 27, 2024

Risk Score:82 / 100 Bug Hotspots:4 Resilience Coverage:33%

Mitigations

Completing required mitigations increases Resilience Coverage.

  • (Required) Code Review 🔍 Detected
  • (Required) Feature Flag
  • (Required) Integration Test 🔍 Detected
  • (Required) Observability
  • (Required) QA Review
  • (Required) Run Nightly Tests
  • Unit Test
Risk Summary:

The pull request has a high-risk score of 82, primarily driven by predictors such as the average age of files, cognitive complexity within files, and the delta of executable lines. Historically, PRs with these predictors are 113% more likely to cause a bug than the repository baseline. Additionally, it modifies 4 files that have shown elevated levels of bug fixes recently. Although the observed bug trend in the repository is decreasing, the predicted bug trend suggests a potential increase in issues.

Note: The risk score is not based on semantic analysis but on historical predictors of bug occurrence in the repository. The attributes above were deemed the strongest predictors based on that history. Predictors and the score may change as the PR evolves in code, time, and review activity.

Bug Hotspots:
What's This?

File Percentile
../durable/persist.rs 97
../src/main.rs 94
../src/durable.rs 99
../durable/transaction.rs 96

Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/catalog/src/durable/upgrade.rs Outdated Show resolved Hide resolved
src/environmentd/tests/testdata/http/ws Outdated Show resolved Hide resolved
@rjobanp rjobanp enabled auto-merge August 27, 2024 18:00
@rjobanp rjobanp merged commit 4f041c5 into MaterializeInc:main Aug 27, 2024
85 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
@rjobanp rjobanp deleted the source-references-catalog branch August 27, 2024 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants