Move MinMax type into mz-ore
#29222
Merged
Move MinMax type into mz-ore
#29222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjobanp
approved these changes
Aug 26, 2024
rjobanp
reviewed
Aug 26, 2024
src/ore/src/stats.rs
Outdated
| /// The push stack and the pop stack, merged into one allocation to optimize memory usage. | ||
| /// | ||
| /// The push stack is the first `push_stack_len` items, the pop stack is the rest. | ||
| /// The push stack grows to the left, the pop stack grows to the right. |
There was a problem hiding this comment.
Reading this more carefully, shouldn't this be the push stack grows to the right, pop stack to the left?
In the diagram below the arrows indicate that's what's happening, and it seems that the code does too (top of push stack = push_stack_len)
benesch
approved these changes
Aug 26, 2024
src/ore/src/stats.rs
Outdated
| /// The push stack and the pop stack, merged into one allocation to optimize memory usage. | ||
| /// | ||
| /// The push stack is the first `push_stack_len` items, the pop stack is the rest. | ||
| /// The push stack grows to the left, the pop stack grows to the right. |
This commit moves the `MinMax` type supporting the compute controller metrics into the mz-ore crate, as it might be generally useful. The type is also renamed to `SlidingMinMax` to make its purpose more obvious outside the a metrics context.
|
TFTRs! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
MinMaxtype supporting the compute controller metrics into the mz-ore crate, as it might be generally useful. The type is also renamed toSlidingMinMaxto make its purpose more obvious outside the a metrics context.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.